Add UnreferencedAftFibAckUnsupported deviation by mudhireddy · Pull Request #4197 · openconfig/featureprofiles

mudhireddy · 2025-05-12T22:52:50Z

Add a new deviation to skip fiback verification for unreferenced NH, NHG aft entries as part of testing

OpenConfigBot · 2025-05-12T22:53:06Z

Pull Request Functional Test Report for #4197 / `acee215`

Virtual Devices

Device	Test	Test Documentation	Job	Raw Log
Arista cEOS		TE-15.1: gRIBI Compliance
Cisco 8000E		TE-15.1: gRIBI Compliance
Cisco XRd		TE-15.1: gRIBI Compliance
Juniper ncPTX		TE-15.1: gRIBI Compliance
Nokia SR Linux		TE-15.1: gRIBI Compliance
Openconfig Lemming		TE-15.1: gRIBI Compliance

Hardware Devices

Device	Test	Test Documentation	Raw Log
Arista 7808		TE-15.1: gRIBI Compliance
Cisco 8808		TE-15.1: gRIBI Compliance
Juniper PTX10008		TE-15.1: gRIBI Compliance
Nokia 7250 IXR-10e		TE-15.1: gRIBI Compliance

Help

coveralls · 2025-05-12T23:00:32Z

Pull Request Test Coverage Report for Build 15087674661

Details

0 of 8 (0.0%) changed or added relevant lines in 2 files are covered.
No unchanged relevant lines lost coverage.
Overall coverage decreased (-0.01%) to 18.03%

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
internal/deviations/deviations.go	0	3	0.0%
proto/metadata_go_proto/metadata.pb.go	0	5	0.0%

Totals
Change from base Build 15079550658:	-0.01%
Covered Lines:	2478
Relevant Lines:	13744

💛 - Coveralls

mudhireddy · 2025-05-12T23:01:34Z

@nflath, fyi, This one replaces #4189

mudhireddy · 2025-05-20T18:54:34Z

@nflath , Can you please provide your comments on this pull request

mudhireddy · 2025-07-08T02:23:21Z

Can someone review this please?

nflath · 2025-07-08T15:02:06Z

What is the rationale for this?

mudhireddy · 2025-07-10T03:45:25Z

What is the rationale for this?

Arista's EOS will not install entries into hardware if there are no references to the afts by design and will not send FIB_ACK for those.

NextHopGroup gets installed only when there is an IP aft that uses it.
NextHop gets installed only when there is at least one installed NextHopGroup that uses it.

This test expects to receive FIB_ACK for NH which are referenced by NHG but there is no IP aft that references NHG. So EOS will not support it and hence this deviation.

mudhireddy · 2025-08-14T17:00:44Z

@nflath , hope that answers your question. let me know if you need any further details and if not can you please approve this request

gggsmith · 2025-08-15T09:20:34Z

@nflath , hope that answers your question. let me know if you need any further details and if not can you please approve this request

@mudhireddy as the behaviour is inconsistent with gribi specification - it would also be great to know if there are any existing discussions or tracking items (e.g., feature requests or bug reports) regarding Arista's plans for support for this specific part of the specification.

gggsmith

Instead of using a deviation for this, we'd prefer a different approach. It's important that we have clear visibility into which tests are affected by this non-compliance, and we can't let a "green" status mask these issues.

With that in mind, please create a separate test for this and move all the failing test cases into it.

Thank you!

mudhireddy · 2025-09-17T22:02:24Z

Thanks for the review. sure I can create a separate test-suite for failing cases.

Test cases for this feature profile test is coming from a different repo as per README.md file which is https://github.com/openconfig/gribigo/tree/main/compliance

I need to separate the failed cases in that repo first and create a PR for it and let it merge. After that I can work on featureprofiles repo to split compliance test as suggested in the review.

Please let me know if this aligns with your expectation and if there are any pitfalls of this approach.

P.S: Is there any documentation available to use to create new test-suites like TE-15.2 in featureprofiles repo ? Thanks.

mudhireddy · 2025-09-18T18:27:00Z

created a PR for splitting gribigo test cases: openconfig/gribigo#266

gggsmith · 2025-09-22T11:05:27Z

Thanks for the review. sure I can create a separate test-suite for failing cases.

Test cases for this feature profile test is coming from a different repo as per README.md file which is https://github.com/openconfig/gribigo/tree/main/compliance

I need to separate the failed cases in that repo first and create a PR for it and let it merge. After that I can work on featureprofiles repo to split compliance test as suggested in the review.

Please let me know if this aligns with your expectation and if there are any pitfalls of this approach.

P.S: Is there any documentation available to use to create new test-suites like TE-15.2 in featureprofiles repo ? Thanks.

Apologies for the late reply. Rather than making the gribigo library aware of different gRIBI support levels, I think we should create a new test (e.g., gribigo_fiback_compliance, TE-15.2) that uses Reference to generate the required test cases.

mudhireddy · 2025-09-22T19:33:51Z

Rather than making the gribigo library aware of different gRIBI support levels, I think we should create a new test (e.g., gribigo_fiback_compliance, TE-15.2) that uses Reference to generate the required test cases.

No worries and Thank you for your reply. I understood it as, use the Reference field for these non-compliant test cases ("TE-3.1.2", "TE-3.1.3") to skip running them as part of TE-15.1 and add a new test suite TE-15.2, gribigo_fiback_compliance that only runs those skipped in TE-15.1. am I interpreting it correct ?

Also can you please point me to a doc(if it exists) that describes how to add new test suite ?

mudhireddy · 2025-09-25T15:46:31Z

Rather than making the gribigo library aware of different gRIBI support levels, I think we should create a new test (e.g., gribigo_fiback_compliance, TE-15.2) that uses Reference to generate the required test cases.

No worries and Thank you for your reply. I understood it as, use the Reference field for these non-compliant test cases ("TE-3.1.2", "TE-3.1.3") to skip running them as part of TE-15.1 and add a new test suite TE-15.2, gribigo_fiback_compliance that only runs those skipped in TE-15.1. am I interpreting it correct ?

Also can you please point me to a doc(if it exists) that describes how to add new test suite ?

@gggsmith ?

Dismissing the review for now to unblock the test fixes activity. We can discuss more on the internal bug for changes.

* Add UnreferencedAftFibAckUnsupported deviation * regenerate metadata.pb.go file * Update gribigo_compliance_test.go --------- Co-authored-by: AmrNJ <155722765+AmrNJ@users.noreply.github.com>

mudhireddy requested review from a team as code owners May 12, 2025 22:52

mudhireddy mentioned this pull request May 12, 2025

Add UnreferencedAftFibAckUnsupported deviation #4189

Closed

mudhireddy force-pushed the unrefAftFibAckDeviation branch 3 times, most recently from 72c0b17 to 4a383dd Compare May 14, 2025 22:06

nikki-blr assigned nflath May 15, 2025

mudhireddy force-pushed the unrefAftFibAckDeviation branch from 4a383dd to 0030d2a Compare May 15, 2025 18:31

Add UnreferencedAftFibAckUnsupported deviation

b745c8d

mudhireddy force-pushed the unrefAftFibAckDeviation branch from 0030d2a to b745c8d Compare May 17, 2025 17:55

gggsmith self-assigned this Jun 30, 2025

gggsmith previously requested changes Aug 18, 2025

View reviewed changes

nflath removed their assignment Sep 18, 2025

mudhireddy mentioned this pull request Sep 18, 2025

split NextHop fiback compliance testcases openconfig/gribigo#266

Open

gggsmith self-requested a review September 22, 2025 11:07

rohit-rp approved these changes Jun 15, 2026

View reviewed changes

mudhireddy added 2 commits June 15, 2026 10:17

Merge branch 'main' into unrefAftFibAckDeviation

e6c0dcc

regenerate metadata.pb.go file

ecc173e

AmrNJ unassigned gggsmith Jun 16, 2026

Update gribigo_compliance_test.go

acee215

AmrNJ merged commit e915a0a into openconfig:main Jun 16, 2026
18 checks passed

mudhireddy deleted the unrefAftFibAckDeviation branch June 16, 2026 20:14

Uh oh!

Conversation

mudhireddy commented May 12, 2025

Uh oh!

OpenConfigBot commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Functional Test Report for #4197 / acee215

Virtual Devices

Hardware Devices

Uh oh!

coveralls commented May 12, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Test Coverage Report for Build 15087674661

Details

💛 - Coveralls

Uh oh!

mudhireddy commented May 12, 2025

Uh oh!

mudhireddy commented May 20, 2025

Uh oh!

mudhireddy commented Jul 8, 2025

Uh oh!

nflath commented Jul 8, 2025

Uh oh!

mudhireddy commented Jul 10, 2025

Uh oh!

mudhireddy commented Aug 14, 2025

Uh oh!

gggsmith commented Aug 15, 2025

Uh oh!

gggsmith left a comment

Choose a reason for hiding this comment

Uh oh!

mudhireddy commented Sep 17, 2025

Uh oh!

mudhireddy commented Sep 18, 2025

Uh oh!

gggsmith commented Sep 22, 2025

Uh oh!

mudhireddy commented Sep 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mudhireddy commented Sep 25, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

OpenConfigBot commented May 12, 2025 •

edited

Loading

Pull Request Functional Test Report for #4197 / `acee215`

coveralls commented May 12, 2025 •

edited

Loading

mudhireddy commented Sep 22, 2025 •

edited

Loading